Fix POSIX compliance in send-heartbeat string comparison#1518
Merged
gsanchietti merged 2 commits intomy_migrationfrom Feb 11, 2026
Merged
Fix POSIX compliance in send-heartbeat string comparison#1518gsanchietti merged 2 commits intomy_migrationfrom
gsanchietti merged 2 commits intomy_migrationfrom
Conversation
Co-authored-by: gsanchietti <804596+gsanchietti@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on sending data to new enterprise portal proxy
Fix POSIX compliance in send-heartbeat string comparison
Feb 11, 2026
gsanchietti
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
send-heartbeatscript uses#!/bin/shbut was using==for string comparison, which is a bash extension and not POSIX-compliant.Changes:
==to=in string comparison (line 26)send-inventoryand other shell scriptsThis ensures compatibility with all POSIX-compliant shells.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.